Skip to content

Prevent layer updates when changing selected layer#1105

Merged
martinRenou merged 1 commit intogeojupyter:mainfrom
gjmooney:layer-click-rerender
Feb 5, 2026
Merged

Prevent layer updates when changing selected layer#1105
martinRenou merged 1 commit intogeojupyter:mainfrom
gjmooney:layer-click-rerender

Conversation

@gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Feb 5, 2026

Description

When selecting a new layer, RJSF would trigger an onChange event, which ultimately ended with an unnecessary call to the shared models updateLayer, triggering layer updates in the MainView. This adds a little boolean to only sync the form with the shared model on user initiated changes.

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint
  • If you wish to be cited for your contribution, CITATION.cff contains an author entry for yourself

📚 Documentation preview: https://jupytergis--1105.org.readthedocs.build/en/1105/
💡 JupyterLite preview: https://jupytergis--1105.org.readthedocs.build/en/1105/lite

@gjmooney gjmooney added the bug Something isn't working label Feb 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/layer-click-rerender

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Integration tests report: appsharing.space

@martinRenou martinRenou merged commit 1c87e4d into geojupyter:main Feb 5, 2026
27 of 29 checks passed
@gjmooney gjmooney deleted the layer-click-rerender branch February 5, 2026 17:44
gjmooney added a commit to gjmooney/jupytergis that referenced this pull request Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants