Prevent layer updates when changing selected layer#1105
Merged
martinRenou merged 1 commit intogeojupyter:mainfrom Feb 5, 2026
Merged
Prevent layer updates when changing selected layer#1105martinRenou merged 1 commit intogeojupyter:mainfrom
martinRenou merged 1 commit intogeojupyter:mainfrom
Conversation
Contributor
Contributor
|
Integration tests report: appsharing.space |
gjmooney
added a commit
to gjmooney/jupytergis
that referenced
this pull request
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When selecting a new layer, RJSF would trigger an onChange event, which ultimately ended with an unnecessary call to the shared models
updateLayer, triggering layer updates in theMainView. This adds a little boolean to only sync the form with the shared model on user initiated changes.Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lintCITATION.cffcontains an author entry for yourself📚 Documentation preview: https://jupytergis--1105.org.readthedocs.build/en/1105/
💡 JupyterLite preview: https://jupytergis--1105.org.readthedocs.build/en/1105/lite